analogdevicesinc
dev/ad4080 adalm_mmsc
Pull Request Description
Please replace this with a detailed description and motivation of the changes. You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR. If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
- [ ] Bug fix (change that fixes an issue)
- [x] New feature (change that adds new functionality)
- [ ] Breaking change (has dependencies in other repos or will cause CI to fail)
PR Checklist
- [x] I have followed the Coding style guidelines
- [x] I have complied with the Submission Checklist
- [x] I have performed a self-review of the changes
- [x] I have commented my code, at least hard-to-understand parts
- [x] I have build all projects affected by the changes in this PR
- [x] I have tested in hardware affected projects, at the relevant boards
- [x] I have signed off all commits from this PR
- [x] I have updated the documentation (wiki pages, ReadMe etc), if applies
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nacuna-adi :
- on the naming of the project - rather than "ad4080", consider naming it "adalm-mmsc". That allows you to go beyond just the AD4080, add gpio / one-bit-adc-dacs for frequency control, heartbeat LED, and other features specific to this setup. there is precedent, see the swiot1l project.
- Update iio attribute names and add missing attributes to be consistent with the upstreamed Linux driver. This should work with the pyadi-iio example in this PR: https://github.com/analogdevicesinc/pyadi-iio/pull/669
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.
@nacuna-adi Can you split the commits into changes in the existing driver, and the addition of new iio driver, iio driver doc, new project, and new project doc?
Might be good to rename the project folder to ad4080_adalm or something else related to the board if there are components in the board that is not applicable to the original AD4080 evkit.
Rebase to the latest main and resolve conflict on the rst file so the CI can run.
hello Antoniu (@amiclaus). I have addressed your round 1 PR comments. Requesting round 2 of review.
@nacuna-adi can you post the binary on our internal site and tag me? I assume you are verifying on the hardware as well. Thanks!