enum max_uart_flow_ctrl Naming Difference for MAX32670

Open kilicomercan opened this issue 10 months ago • 1 comments

Uart flow control enumeration is defined as

enum max_uart_flow_ctrl { UART_FLOW_DIS, UART_FLOW_EN };

for other MAX32XXX parts except MAX32670 in no-OS/drivers/platform/maxim/max32670/maxim_uart.h file. This enum has been defined as, enum max_uart_flow_ctrl { MAX_UART_FLOW_DIS, MAX_UART_FLOW_EN }; for MAX32670.

So, developer needs to configure the application implementation according to the part number. It might be better to have a generic naming for this enum. If we apply this change, we should also update the example projects using uart for MAX32670.

Feb 27 '25 07:02 kilicomercan

thanks for reporting, i agree, they need to have the same name ! i would use the one with MAX_ prefix to reduce the chances of namespace conflicts, would you like to create a pull request ?

Mar 07 '25 11:03 buha