no-OS icon indicating copy to clipboard operation
no-OS copied to clipboard

dma api

Open CiprianRegus opened this issue 1 year ago • 1 comments

Pull Request Description

Please replace this with a detailed description and motivation of the changes. You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR. If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • [ ] Bug fix (change that fixes an issue)
  • [ ] New feature (change that adds new functionality)
  • [ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • [ ] I have followed the Coding style guidelines
  • [ ] I have performed a self-review of the changes
  • [ ] I have commented my code, at least hard-to-understand parts
  • [ ] I have build all projects affected by the changes in this PR
  • [ ] I have tested in hardware affected projects, at the relevant boards
  • [ ] I have signed off all commits from this PR
  • [ ] I have updated the documentation (wiki pages, ReadMe etc), if applies

CiprianRegus avatar Jan 26 '24 13:01 CiprianRegus

I would say this looks very good.

One remaining discussion would be the mutex functionality that should be placed in pretty much anything under drivers/api. You have those acquire/release API's which map well onto a mutex locking mechanism so I'd say we should add it at this stage. Might be tricky to test though...

buha avatar Mar 08 '24 12:03 buha

  • Added mutex_* calls in the no_os_dma API.
  • Fixed a merge conflict.

CiprianRegus avatar Mar 18 '24 13:03 CiprianRegus

in case you didnt notice, some CI tests are not passing, this is the error:

/no-OS_builds/builds_main/build_maxim/app/noos/drivers/platform/maxim/max32690/maxim_irq.c:48:10: fatal error: maxim_dma.h: No such file or directory
   48 | #include "maxim_dma.h"
      |          ^~~~~~~~~~~~~

buha avatar Mar 19 '24 07:03 buha