no-OS icon indicating copy to clipboard operation
no-OS copied to clipboard

Published 20 hours ago • verified publisher icon analogdevicesinc

drivers:rf-transceiver:ad9361:ad9361.c: Rx Tx FIR len must match

Open kylex2 opened this issue 3 years ago • 3 comments

This is apparently not documented in any public document. Please see https://github.com/analogdevicesinc/ad936x-filter-wizard/issues/43. This adds check to make sure the Rx and Tx number of FIR taps matches.

Signed-off-by: Alexander Vickberg [email protected]

kylex2 avatar Feb 15 '22 15:02 kylex2

Edited PR description to make sense and match commit description. Revert the changes if they are not appropriate.

adrimbarean avatar Feb 16 '22 12:02 adrimbarean

I have added a missing return

kylex2 avatar Feb 16 '22 13:02 kylex2

It would be neat if this could be assigned to someone who can confirm/deny the need for this change. I have to confess that I kind of made this pull request to get this behavior of the chip confirmed/denied.

kylex2 avatar Mar 04 '22 14:03 kylex2

@kylex2 , I opened an EngineerZone thread on your behalf and asked this question to adrv9361 design engineers, Apparently it's not necessary the filter lengths match so I will close this PR.

https://ez.analog.com/wide-band-rf-transceivers/design-support/f/q-a/569811/rx-tx-fir-length---must-they-match/494452

buha avatar May 22 '23 09:05 buha