hdl icon indicating copy to clipboard operation
hdl copied to clipboard

Published 20 hours ago • verified publisher icon analogdevicesinc

spi_engine: Create interface_ip.tcl

Open gastmaier opened this issue 1 year ago • 3 comments

PR Description

Use tcl script instead of static xmls for the interface. Easier to mantain and are not gitignored.

PR Type

  • [ ] Bug fix (change that fixes an issue)
  • [ ] New feature (change that adds new functionality)
  • [ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • [X] I have followed the code style guidelines
  • [X] I have performed a self-review of changes
  • [ ] I have compiled all hdl projects and libraries affected by this PR
  • [ ] I have tested in hardware affected projects, at least on relevant boards
  • [X] I have commented my code, at least hard-to-understand parts
  • [X] I have signed off all commits from this PR
  • [ ] I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • [X] I have not introduced new Warnings/Critical Warnings on compilation
  • [ ] I have added new hdl testbenches or updated existing ones

gastmaier avatar Jan 18 '24 14:01 gastmaier

This pr had the unfortunate side effect of requiring renaming spi_master to spi_engine because dynamic interfaces need to be prefixed by the IP name. Alternatively, I could have renamed to spi_engine_master instead of spi_engine, however for the other framework, I'm using the IP name as the interface, and for consistence I named the interface the IP name.

gastmaier avatar Jan 30 '24 18:01 gastmaier

This pr had the unfortunate side effect of requiring renaming spi_master to spi_engine

And unfortunately the copyright year for all the edited files should be updated to contain 2024 as well... so for example if it was "2017, 2019, 2022", you would have to add ", 2024" and not a range.

IuliaCMoldovan avatar Jan 31 '24 11:01 IuliaCMoldovan

Done, all projects/libraries were edited on 2023, so I extended the range. I will squash the commits on merge.

gastmaier avatar Jan 31 '24 12:01 gastmaier

Please fix conflicts

sarpadi avatar Feb 26 '24 13:02 sarpadi

Force pushed to update cn0540 common db, that on pr #1207 changed to use the spi_engine script. Now the only change on this file is the interface itself

gastmaier avatar Feb 26 '24 14:02 gastmaier

running "make clean" inside "/hdl/library/spi_engine/interfaces" does not remove .sv files

sarpadi avatar Feb 27 '24 09:02 sarpadi

I added to the removal list for every /**/interfaces/ and updated the .gitignore on 7539df769.

gastmaier avatar Feb 27 '24 20:02 gastmaier