hdl
hdl copied to clipboard
ADD adaq42xx
PR Description
Added initial version of adaq42xx with and without fully isolated power supply based on AD463x
PR Type
- [ ] Bug fix (change that fixes an issue)
- [x] New feature (change that adds new functionality)
- [ ] Breaking change (has dependencies in other repos or will cause CI to fail)
PR Checklist
- [x] I have followed the code style guidelines
- [x] I have performed a self-review of changes
- [x] I have compiled all hdl projects and libraries affected by this PR
- [x] I have tested in hardware affected projects, at least on relevant boards
- [x] I have commented my code, at least hard-to-understand parts
- [x] I have signed off all commits from this PR
- [ ] I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
- [ ] I have not introduced new Warnings/Critical Warnings on compilation
- [ ] I have added new hdl testbenches or updated existing ones
v1:
- Reduced the number of files as requested by Adrian
- Addressed the findings
- Fixed the AD4030 and AD4630 xdc, sdi lines are is different for different number of used SDIs used
Please update zed/readme file with new parameter, valid values and example(s)
instead of using 0 and 1 to choose the device, could we try using the name? https://github.com/analogdevicesinc/hdl/blob/dev_adaq4224_main/projects/ad4630_fmc/common/ad4x3x_bd.tcl#L95-L102
something like this:
switch $S_FPGA_CARRIER {
ZCU102 { ... }
K26I { ... }
default { ... }
}
We could use a variable like "DEVICE"
make DEVICE=AD4630 etc
v2:
- Addressed and fixed comments