hdl icon indicating copy to clipboard operation
hdl copied to clipboard

ADD adaq42xx

Open ladace opened this issue 1 year ago • 3 comments

PR Description

Added initial version of adaq42xx with and without fully isolated power supply based on AD463x

PR Type

  • [ ] Bug fix (change that fixes an issue)
  • [x] New feature (change that adds new functionality)
  • [ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • [x] I have followed the code style guidelines
  • [x] I have performed a self-review of changes
  • [x] I have compiled all hdl projects and libraries affected by this PR
  • [x] I have tested in hardware affected projects, at least on relevant boards
  • [x] I have commented my code, at least hard-to-understand parts
  • [x] I have signed off all commits from this PR
  • [ ] I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • [ ] I have not introduced new Warnings/Critical Warnings on compilation
  • [ ] I have added new hdl testbenches or updated existing ones

ladace avatar Nov 03 '23 10:11 ladace

v1:

  • Reduced the number of files as requested by Adrian
  • Addressed the findings
  • Fixed the AD4030 and AD4630 xdc, sdi lines are is different for different number of used SDIs used

ladace avatar Dec 07 '23 13:12 ladace

Please update zed/readme file with new parameter, valid values and example(s)

sarpadi avatar Jan 11 '24 09:01 sarpadi

instead of using 0 and 1 to choose the device, could we try using the name? https://github.com/analogdevicesinc/hdl/blob/dev_adaq4224_main/projects/ad4630_fmc/common/ad4x3x_bd.tcl#L95-L102

something like this:

switch $S_FPGA_CARRIER {
  ZCU102 {  ...  }
  K26I {  ...  }
  default { ... }
}

We could use a variable like "DEVICE"

make DEVICE=AD4630 etc

sarpadi avatar Jan 11 '24 13:01 sarpadi

v2:

  • Addressed and fixed comments

ladace avatar Apr 02 '24 07:04 ladace