Andrii Nakryiko

Results 153 comments of Andrii Nakryiko

@woodpenker would you be able to send a PR with this change?

Libbpf's BPF_KPROBE macro currently doesn't support more than 5 arguments. Please contribute the patch to extend it. For now to unblock yourself you can add this before BPF_KPROBE macro use:...

@ThinkerYzu1 yes, selftests can serve as an example, but having minimal self-contained and simple examples in libbpf-bootstrap is extremely helpful. I do agree that we should either add a separate...

Should be addressed by https://github.com/libbpf/libbpf/issues/617

Did you test this code? Did it work? From what I see, by the time ProgramInfo is returned to user that fd is already closed. I think the right way...

> What are your thoughts on moving the close to the `Drop` handler for the `Info` types? At least then (from what I understand), we keep bpf object alive for...

> We already pay the cost of [opening all the fds](https://github.com/libbpf/libbpf-rs/blob/master/libbpf-rs/src/query.rs#L42) but we `close` them before passing the `Info` type to the user. The bpf object might not be alive...

Should be addressed by https://github.com/libbpf/libbpf/issues/617

@tohojo, with LLVM9 you also won't need pahole for BTF generation, so that's a double win: you can get rid of a good chunk of sample Makefile ;)

make sure you are linking against zlib (pass -lz during compilation) and make sure you have zlib in LD_LIBRARY_PATH?