Performance degradation between v1.56.1 and v1.58.1

[viciious]

Hi!

Sorry for being so vague about the issue, but users of the library in our corporate network have reported performance issues with our bittorrent client after was upgraded from v1.56.1 to v1.58.1. The main symptom is slow download times. One thing I noticed after updating is that whenever a new torrent is initialized on the leecher, the application log is flooded with the following kind of messages:

"message":"543f82beb3062cd1d40e3878710585e6e809d13b: error hashing piece 0: open 1.tar.zst: no such file or directory"
"message":"543f82beb3062cd1d40e3878710585e6e809d13b: error hashing piece 1: open 1.tar.zst: no such file or directory"
"message":"543f82beb3062cd1d40e3878710585e6e809d13b: error hashing piece 2: open 1.tar.zst: no such file or directory"
...

and so on and so forth, whereas the log used to be the following:

"message":"hashed piece 0 (passed=false)"
"message":"hashed piece 2 (passed=false)"
"message":"hashed piece 3 (passed=false)"
...

Any help would be appreciated. Thanks!

[anacrolix]

Thanks, the logging was recently spotted, can you try the erigon branch?

[viciious]

Do you think the performance issue might be fixed on that branch?

Also, we probably want this change to be included on the branch too: https://github.com/anacrolix/torrent/commit/f4dc49bf8c3cfa69df3b85c92b07ce67afabc1c2

[anacrolix]

I don't recall but I knew it was an issue. I think there was another issue where piece completion was modified under a lock but I don't know if that would be the cause. It was fixed too.

You're welcome to merge that TOS commit into a branch based on the erigon branch. I'll fold it all back in to master soon enough.