An Tao

Results 208 comments of An Tao

> @an-tao Thank you for your review! I've fixed both as reviewed. Thanks, please rebase on the new master branch.

> @an-tao > > Could you please check why the bad-free error occurs? https://github.com/drogonframework/drogon/runs/7778696421?check_suite_focus=true#step:15:46755 I can't say where is the problem with this error, maybe we could try to use...

@ken-matsui please rebase on the master branch, thanks.

Basically you can't, your controller is called only when complete requests arriving, drogon use the mmap api of files for large request, so large data requests don't occupy memory too...

you need to modify the HttpServer class

Drogon doesn't support protobuf specially, you could implement this part yourself, particularly, you can implement the fromRequest (or toResponse, etc.) template like: ``` template std::shared_ptr fromRequest(const HttpRequest &req); ```

What's your OS and compiler? Did you create the project via drogon_ctl?

Try to create a new one, and update your old CmakeLists.txt (use diff comand to find the difference of them)

The default gcc version of centOs is low, and it is recommended to use drogon after upgrading gcc(newer than gcc9).

@itlabers Thanks for your feedback, but I can't reproduce this issue in my enverionment. Could you try to fix this yourself and make a PR for it?