finite_ntk malaria data generation bug + questions

[tingtang2]

Bug

I think test_year is supposed to be train_year in line 55 right?

https://github.com/amzn/xfer/blob/dd4a6a27ca00406df83eec5916d3a76a1a798248/finite_ntk/data.py#L40-L55

Questions

I see the variables inside, extent and grid_x being declared but not used in the malaria experiments. I'm looking to replicate the experiments in JAX so I was wondering what the original purpose of these variables were. In particular, what is the sparse tensor for marking Nigeria and inside supposed to be doing?

https://github.com/amzn/xfer/blob/dd4a6a27ca00406df83eec5916d3a76a1a798248/finite_ntk/data.py#L80-L100

P.S. thank you for the work and for releasing the code!

[wjmaddox]

Ugh, yeah, that looks like a bug. Let me put up a PR to fix (idk who has write access to this still however).

For the second question, you shouldn't need to copy those over.