xfer icon indicating copy to clipboard operation
xfer copied to clipboard

current_pars not used

Open evcu opened this issue 3 years ago • 1 comments

Maybe I am missing something. I don't see where current_pars argument is used inside the losses. Is it used, if not I guess why it is passed?

https://github.com/amzn/xfer/blob/dd4a6a27ca00406df83eec5916d3a76a1a798248/finite_ntk/experiments/cifar/losses.py#L22

evcu avatar Oct 28 '21 19:10 evcu

You're correct that it probably shouldn't be passed / used, as the loss functions use the current pars after we return the callable.

wjmaddox avatar Oct 28 '21 21:10 wjmaddox