style-dictionary icon indicating copy to clipboard operation
style-dictionary copied to clipboard

chore(deps): Migrate from node-sass to dart-sass

Open arnaud-ritti opened this issue 9 months ago • 2 comments

Description of changes:

Migrate from the deprecated node-sass to dart-sass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

arnaud-ritti avatar Oct 02 '23 10:10 arnaud-ritti

Hi @dbanksdesign

Any chance for reviewing this in a predictable time? Would appreciate it a lot.

notbear avatar Jan 16 '24 12:01 notbear

Hey, I actually migrated to dart-sass already in the v4 branch, which is released as a prerelease already.

Two questions:

  • Can you use the v4 prerelease for your use case? If not, can you explain why you need to have this change in v3, what exactly is making it blocking for you?
  • The cssEscape utility, can you explain what it does and why it's needed, and perhaps add some tests to document this? I don't have this part of your changes in the v4 branch yet, the rest of it (tests mostly) I do

jorenbroekema avatar Jan 17 '24 12:01 jorenbroekema