jekyll-doc-project icon indicating copy to clipboard operation
jekyll-doc-project copied to clipboard

sidebar subfolder and subsubfolder http urls not linked

Open mmraz opened this issue 1 year ago • 1 comments

The conditional check for an http/https jurl in _includes/sidebar.html for subfolderitem and subsubfolderitem items are checking the parent folderitem.jurl instead of their depth's value. This should be a changed in the following places.

https://github.com/amzn/jekyll-doc-project/blob/8a819e5ff9aa1d8f6a82f08a5a9fb41b0cc11c50/_includes/sidebar.html#L61

https://github.com/amzn/jekyll-doc-project/blob/8a819e5ff9aa1d8f6a82f08a5a9fb41b0cc11c50/_includes/sidebar.html#L76

mmraz avatar Mar 20 '24 14:03 mmraz

Opened PR https://github.com/amzn/jekyll-doc-project/pull/4 from my fork to remediate.

mmraz avatar Mar 20 '24 15:03 mmraz