ion-rust icon indicating copy to clipboard operation
ion-rust copied to clipboard

Define an MSRV policy for the crate

Open zslayton opened this issue 1 year ago • 3 comments

          > while we still can

There's a cfg_version RFC that will help with this.

Also, if we haven't already done so, we should define a MSRV policy for this crate.

Originally posted by @popematt in https://github.com/amazon-ion/ion-rust/pull/796#discussion_r1672709415

zslayton avatar Jul 23 '24 21:07 zslayton

I propose stealing the MSRV policy from the jiff crate, as it seems reasonable to me:

This crate's minimum supported rustc version is 1.70.0.

The policy is that the minimum Rust version required to use this crate can be increased in minor version updates. For example, if jiff 1.0 requires Rust 1.20.0, then jiff 1.0.z for all values of z will also require Rust 1.20.0 or newer. However, jiff 1.y for y > 0 may require a newer minimum version of Rust.

zslayton avatar Jul 23 '24 21:07 zslayton

@zslayton, would it be fair to summarize that as "increasing the MSRV requires a new minor version"?

Another one that looks reasonable to me is this proposal for libc.

popematt avatar Jul 23 '24 22:07 popematt

would it be fair to summarize that as "increasing the MSRV requires a new minor version"?

Yes, without a "we support the last N releases" requirement. I could get behind a "last N" policy for a sufficiently small N.

zslayton avatar Jul 23 '24 23:07 zslayton