credence-to-causal-estimation icon indicating copy to clipboard operation
credence-to-causal-estimation copied to clipboard

Remove S3 paths from notebooks

Open willettk opened this issue 3 years ago • 2 comments

As pointed out by @harsh-parikh, there are several S3 buckets mentioned in the new notebook. S3 buckets shouldn't be included in any commits to this repo (even if access is restricted) unless the bucket is fully public and has been approved. Will have to keep those references in internal documentation.

https://github.com/amzn/credence-to-causal-estimation/blob/credence_new_structure_new_marginal_likelihood/notebooks/example-new-structure.ipynb

willettk avatar Apr 01 '21 18:04 willettk

One possibility would be adding a pre-commit hook to check for S3 paths before allowing commits? Maybe something like git-secrets.

willettk avatar Apr 01 '21 18:04 willettk

S3 buckets are removed from all branches with the same notebook. And all branches pass git-secrets scans, after adding a specific pattern for s3 paths.

Louisexu925 avatar Apr 12 '21 19:04 Louisexu925