amupedia-web icon indicating copy to clipboard operation
amupedia-web copied to clipboard

Contact form submission error fixed

Open BhavinRaichura opened this issue 1 year ago • 4 comments

Description

This pull request addresses the following issues:

  1. Fixed a bug in the form validation code within the form submit handler of the contact form. The bug was causing the form validation process to malfunction, leading to unsuccessful form submissions. This fix ensures that the form validation works correctly, allowing successful form submissions.
  2. Resolved a bug in the API that was not working as expected. The API is now fixed and functioning properly, ensuring that requests to the API return the expected responses.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • [x] The app is working correctly after applying the changes.
  • [x] The app is responsive and displays properly on different screen sizes and devices.
  • [x] The changes are thoroughly documented in the appropriate files or documentation sections.
  • [x] The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • [x] I have tested the changes locally and ensured that the app is functioning as expected.
  • [x] I have verified that the app is responsive and looks good on various screen sizes and devices.
  • [x] I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • [x] I have followed the coding conventions and style guidelines defined in the project.
  • [x] I have run the automated tests and all of them pass.
  • [x] I have considered the performance implications of the changes made.
  • [x] I have considered the security implications of the changes made.
  • [x] I have checked for any potential regressions or side effects caused by the changes.
  • [x] I have performed a self-review of my code.
  • [x] Starred the repository.
  • [ ] Added My Name to the Contributor's List.
  • [x] Followed the repository's Contributing Guidelines.
  • [x] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

contact form successful submission message Response in console

Additional Notes(Optional)

  1. [x] Fixed a bug in the form validation code within the form submit handler of the contact form.

    • [x] The form validation process was malfunctioning, causing unsuccessful form submissions.
    • [x] The fix ensures that the form validation works correctly, allowing successful form submissions.
  2. [x] Resolved a bug in the API that was not working as expected.

    • [x] The API was fixed and is now functioning properly.
    • [x] Requests to the API now return the expected responses.
  3. [x] Appropriate notification for each type of response in the form

  4. [x] Tested the changes locally to ensure the app is functioning as expected.

    • [x] Verified that the app works without any issues after applying the fixes.

Related Issues

[BUG] -Error submitting contact form #565

Reviewers

@tech-bash

BhavinRaichura avatar Jul 24 '23 09:07 BhavinRaichura

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 9:24am

vercel[bot] avatar Jul 24 '23 09:07 vercel[bot]

Thank you, @BhavinRaichura, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇 Please make sure you have marked all the completed tasks as done. ✅ We appreciate your patience and contribution! 😀

github-actions[bot] avatar Jul 24 '23 09:07 github-actions[bot]

Great work! But instead of prepending a notification image maybe you can have a checked image. And try to make the UI kind of like more mature .. Rest all looks fine. Thank you!

tech-bash avatar Jul 31 '23 19:07 tech-bash

Sure I will

BhavinRaichura avatar Aug 01 '23 06:08 BhavinRaichura