amundsen icon indicating copy to clipboard operation
amundsen copied to clipboard

Adopt Airbnb-Typescript Code Guidelines on the Frontend library

Open Golodhros opened this issue 4 years ago • 4 comments

We have setup code linting with ESLint and added some basic rules like the 'react/recommended' to our project.

To make sure we use best practices, reduce our code review effort and provide the best developer experience for our contributors, I suggest to extend the linting rules with the Airbnb rules for Typescript.

Possible Implementation

This rules are already added on the system, but they trigger warnings at the moment. The work on this ticket would entail removing the warnings so they become errors and one by one, fix those issues.

Context

Following strict coding rules for our code benefits Amundsen as:

  • We spend less time on code reviews
  • We provide a great developer experience to our contributors, increasing the chances of obtaining more help and reducing churn
  • We signal that we are a serious project that care about code quality and good practices
  • We make subsequent changes easier

Golodhros avatar Jun 09 '20 21:06 Golodhros

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jun 23 '20 22:06 stale[bot]

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

stale[bot] avatar Jul 15 '20 03:07 stale[bot]

cc @ttannis , I think we need to apply the keep fresh label as well, or we remove the stalebot in this repo.

feng-tao avatar Jul 15 '20 04:07 feng-tao

cc @ttannis , I think we need to apply the keep fresh label as well, or we remove the stalebot in this repo.

I wouldn't remind removing it if we can

ttannis avatar Jul 17 '20 06:07 ttannis