amundsen
amundsen copied to clipboard
feat: Aggregating Alerts Feature
Description
Aggregates alert notices that are passed into the AlertList component and then parses them in the DefinitionList.
Motivation and Context
The UI is cluttered when there are numerous alerts taking up space, especially when many of them have the same title. Aggregating them into one modal alleviates this and reduces the visual strain on the user.
Screenshots (Before)
Notices
Modal
Screenshots (After)
Notices
Modal
Storybook
How Has This Been Tested?
- Utilizing mock data to recreate the notices that can be aggregated as well as without aggregation.
- Unit testing through already existing tests in place
- Verification and updates to storybook and related components
CheckList
- [x] PR title addresses the issue accurately and concisely
- [ ] Updates Documentation and Docstrings
- [x] Adds tests
- [ ] Adds instrumentation (logs, or UI events)
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)
Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.
the feature looks great!
Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.
Ooh that's a good idea, yeah I can do that!
Awesome work, congrats on your first merged pull request!