amundsen icon indicating copy to clipboard operation
amundsen copied to clipboard

feat: Aggregating Alerts Feature

Open jdslaugh opened this issue 1 year ago • 2 comments

Description

Aggregates alert notices that are passed into the AlertList component and then parses them in the DefinitionList.

Motivation and Context

The UI is cluttered when there are numerous alerts taking up space, especially when many of them have the same title. Aggregating them into one modal alleviates this and reduces the visual strain on the user.

Screenshots (Before)

Notices

Screenshot 2024-02-09 at 3 20 46 PM

Modal

Screenshot 2024-02-09 at 3 20 51 PM

Screenshots (After)

Notices

Screenshot 2024-02-09 at 3 18 23 PM

Modal

Screenshot 2024-02-09 at 3 18 18 PM

Storybook

Screenshot 2024-02-09 at 3 41 36 PM

How Has This Been Tested?

  • Utilizing mock data to recreate the notices that can be aggregated as well as without aggregation.
  • Unit testing through already existing tests in place
  • Verification and updates to storybook and related components

CheckList

  • [x] PR title addresses the issue accurately and concisely
  • [ ] Updates Documentation and Docstrings
  • [x] Adds tests
  • [ ] Adds instrumentation (logs, or UI events)

jdslaugh avatar Feb 12 '24 18:02 jdslaugh

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

boring-cyborg[bot] avatar Feb 12 '24 18:02 boring-cyborg[bot]

Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.

Golodhros avatar Feb 15 '24 17:02 Golodhros

the feature looks great!

feng-tao avatar Feb 20 '24 01:02 feng-tao

Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.

Ooh that's a good idea, yeah I can do that!

jdslaugh avatar Feb 22 '24 20:02 jdslaugh

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Feb 29 '24 01:02 boring-cyborg[bot]