amundsen icon indicating copy to clipboard operation
amundsen copied to clipboard

resource name should not contain dot for nested structure to display correctly

Open sajjadGG opened this issue 2 years ago • 1 comments

Expected Behavior

the name of the cluster, data source, schema, and table should be able to contain . and its nested structure should appear correctly

Current Behavior

if one of the mentioned above contains . the nested structure won't appear correctly in the UI

Possible Solution

I suspect the problem is because . is used as a delimiter, and in the parser.ts it uses the database name to guide its nested structure display

Steps to Reproduce

  1. ingest table with cluster name aws.events in sample_data
  2. ingest a nested column in sample col data referencing the mentioned table
  3. use the complex transformer with hive parser to parse the nested structure properly
  4. run the Amundsen locally and ingest the sample data
  5. the nested column won't display correctly
  6. change the cluster name to awsevent and ingest the data again
  7. the nested structure will be displayed correctly

Screenshots (if appropriate)

Correct Behavior with the modified name to awsevent correct behaviour with modified cluster name Current Behavior current behavior

Context

Your Environment

  • Amunsen version used: commit 55e886be6bb2934d834768305ec4061ca41e69e7
  • Data warehouse stores:
  • Deployment (k8s or native): local (with docker-compose)
  • Link to your fork or repository:

sajjadGG avatar Aug 09 '22 08:08 sajjadGG

Thanks for opening your first issue here!

boring-cyborg[bot] avatar Aug 09 '22 08:08 boring-cyborg[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 24 '22 05:09 stale[bot]

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

stale[bot] avatar Oct 16 '22 02:10 stale[bot]