fix: Amundsen Gremlin - issue 1946 - TornadoTransport init correction and moved order direction decr to desc

[ggirodda]

Summary of Changes

1. Removed useless parameters during TornadoTransport initialization
2. Moved Order.decr to Order.desc for gremlin queries using the deprecated order direction (the deprecated Order.decr doesn't work with Neptune)

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

• [x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
• [x] PR includes a summary of changes.
• [ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
• [ ] In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does

[boring-cyborg[bot]]

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

[feng-tao]

CI fails

[ggirodda]

Hi @feng-tao, thank you for your reply. From what I see, the pipeline fails due to flake8 verification on two files that I didn't modify.

python3 -m flake8
./tests/conftest.py:16: [E501] line too long (128 > 120 characters)
./tests/conftest.py:20: [E501] line too long (131 > 120 characters)
Makefile:16: recipe for target 'lint' failed
make: *** [lint] Error 1
Error: Process completed with exit code 2.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sangram23]

Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: marshmallow.exceptions.ValidationError: {'row_count': ['Unknown field.']} Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.146 [DEBUG] action_log_callback.on_post_execution:70 (16429:Thread-30) - Calling callbacks: [<function logging_action_log at 0x7ff321b9eae0>] Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.146 [DEBUG] action_log_callback.logging_action_log:85 (16429:Thread-30) - logging_action_log: ActionLogParams(command='_get_table_metadata', start_epoch_ms=1668671121941, end_epoch_ms=1668671122146, user='root', host_name='ip-xxx-xxx-xxx.ec2.internal', pos_args_json='[]', keyword_args_json='{"table_key": "glue://na_usa_ecs_na-bi-prod_awsglue.awsglue_database_jbtest/aws_glue_jbtest", "index": "0", "source": "inline_search"}', output='{"tableData": {}, "msg": "Encountered exception: {'row_count': ['Unknown field.']}", "status_code": 500}', error=None) Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: /home/ec2-user/amundsen4_gremlin/lib/python3.7/site-packages/flask/json/init.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead. Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: rv = _json.dumps(obj, **kwargs) Nov 17 07:45:22 ip-xxx-xxx-xxx.ec2.internal egdh_frontend4[16429]: 2022-11-17T07:45:22+0000.147 [INFO] _internal._log:225 (16429:Thread-30) - 10.187.63.84 - - [17/Nov/2022 07:45:22] "GET /api/metadata/v0/table?key=glue%3A%2F%2Fna_usa_ecs_na-bi-prod_awsglue.awsglue_database_jbtest%2Faws_glue_jbtest&index=0&source=inline_search HTTP/1.1" 500 -

---

Facing above error on query from frontend. Any Idea ? Seem adding row_count breaking Frontend

[Golodhros]

@ggirodda any news on this?

[ggirodda]

Hi @Golodhros and @sangram23 , sorry for the late answer. The problem is caused by some customization to the table and column structure that I made to the my fork of amundsen. Those modifications are not related to this error. I'll update the pull request with the isolated correction

[ggirodda]

I created a new Pull Request, because I can't change the source branch of this one. The source branch is not yet the master branch. Here is the new PR: https://github.com/amundsen-io/amundsen/pull/2104 I'm closing this one