amundsen icon indicating copy to clipboard operation
amundsen copied to clipboard

Neptune MalformedQueryException

Open ggirodda opened this issue 3 years ago • 3 comments
trafficstars

I started to use amundsen metadata with Neptune database. Initially I used the metadata docker image to interact with the database, but every tested route gave me a 500 internal server error. So I tested it locally, using a VPN to connect to neptune db, and I found 2 problems. I'll do a PR linked to the issue that solves the problems

Expected Behavior

When calling a route of the metadata api for the neptune service, the server should respond without problem

Current Behavior

  1. When calling the api to retrieve (for example) a table description, there's an error got an unexpected keyword argument 'read_timeout'. This error has already be identified in https://github.com/amundsen-io/amundsen/issues/1382
  2. After the correction of 1, another error during the same request
{
    "detailedMessage": "Failed to interpret Gremlin query: Query parsing failed at line 1, character position at 208, error message : token recognition error at: 'dec'",
    "code": "MalformedQueryException",
    "requestId": "25542307-96bb-40d2-9585-5a340b8d868c"
}

Possible Solution

  1. Initialize TornadoTransport class properly, removing read_timeout and write_timeout in gremlin_proxy.py file
  2. Move Order.decrto Order.desc for _get_table_columns and _get_popular_tables_uris functions in gremlin_proxy.py file. The Order.decr and Order.incr are deprecated and don't work with neptune

Steps to Reproduce

  1. Call the /table/{table_uri} metadata route using the gremlin metadata service with AWS Neptune db

Screenshots (if appropriate)

Context

Your Environment

  • Amunsen version used: last (metadata-3.10.0)
  • Data warehouse stores: snowflake
  • Deployment (k8s or native):
  • Link to your fork or repository: https://github.com/ggirodda/amundsen/tree/main

ggirodda avatar Jul 31 '22 23:07 ggirodda

Thanks for opening your first issue here!

boring-cyborg[bot] avatar Jul 31 '22 23:07 boring-cyborg[bot]

The PR that solves the issue in my case https://github.com/amundsen-io/amundsen/pull/1947/files

ggirodda avatar Jul 31 '22 23:07 ggirodda

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Aug 16 '22 02:08 stale[bot]

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

stale[bot] avatar Sep 25 '22 01:09 stale[bot]