anytime_podcast_player
anytime_podcast_player copied to clipboard
amugofjava
Connectivity issues can result in episodes being marked as read.
Describe the bug
Anytime is not distinguishing between an episode stopping because it has come to the end or as a result of a connection issue or drop out. If you have mark played episodes as read enabled in settings, this can result in an episode being marked as played when it hasn't.
To Reproduce Steps to reproduce the behaviour:
- Enable
mark played episodes as read - Begin streaming an episode.
- Enable airplane mode and wait for buffer to run out.
Expected behaviour If, when streaming, an episode stops due to a connectivity error the current play position should be recorded and the episode should not be marked as played.
Hi @amugofjava ,
on current master branch, there is no mark played episodes as read.
Did you mean mark deleted episodes as played ?
Hi, I tried to replicate this bug on the simulator (iphone) but failed: the player remains waiting for connection and does not go into time-out. At that stage, the pause button does not respond to the command. Closed and reopened the application, the episode used as a test, still remains to be read. I also ran the test on an Android device and the behavior is identical.
Hi @mrkrash,
Thanks for checking this out. It looks like this issue has changed since it was logged. Trying this now on iOS, the playback goes into loading state when the buffer is exhausted and stays like that, with the spinner spinning - it doesn't seem to ever time out, which is not good. It's better on Android in that it does eventually timeout, but once the connection is available again it can take two taps on the play button to get it playing again.
Hi @amugofjava, I tried to better understand why it does not go into timed out and it seems that the problem is in just_audio library. The latter does not change state despite the lack of connection. There also seems to be an open issue about it. I'll try to see if there is a way to recover the connection timeout status and, if so, pause the player.
Hi @mrkrash,
Thank you for diving into this. Could you please add a link to the open just_audio issue - I would be interested in taking a look (there are a lot of open issues and couldn't spot this one)?
Thank you.