mglearn icon indicating copy to clipboard operation
mglearn copied to clipboard

prevent print_topics from truncating features

Open alcantarar opened this issue 5 years ago • 3 comments

If printing features of varying lengths, especially when ngram > 1, print_topics output was difficult to interpret. Now adjusts topic width to fit longest feature in that topic.

alcantarar avatar Apr 27 '19 01:04 alcantarar

Thanks for the PR. I'm not sure it's worth adding the feature, though. I'll probably get rid of mglean in the next major rewrite. It was never really meant as a practical tool, only as a companion for replicating figures from the book. With a bit of luck, the plotting functionality will be in sklearn "soon", or I might move to using yellowbrick or dabl for plotting.

amueller avatar Apr 28 '19 19:04 amueller

No worries, seeing it in sklearn would be neat.

alcantarar avatar Apr 28 '19 19:04 alcantarar

Feel free to open an issue there!

amueller avatar Apr 28 '19 19:04 amueller