ORK3 icon indicating copy to clipboard operation
ORK3 copied to clipboard

Global suspended players report missing real names

Open Glenalth opened this issue 5 years ago • 6 comments

https://ork.amtgard.com/orkui/index.php?Route=Reports/suspended

The report here is missing mundane name information when being viewed by logged in officers and admins. Kingdom level reports seem to be functioning properly by blanking the field normally, but filling it in for officers.

Glenalth avatar Sep 23 '19 16:09 Glenalth

@Glenalth can you confirm this view needs names? I want to be sure they weren't removed per the COM request in 2019 for legal issues.

jrtaylor-com avatar Apr 13 '21 17:04 jrtaylor-com

Mundane names should be visible for officers or else it is a useless report. I don't know what the COM request was and am not included on such things.

Glenalth avatar Apr 14 '21 22:04 Glenalth

@Glenalth right now the report will show names for people that have EDIT privileges for the Park/Kingdom the report is being run against. There isn't a check in place to determine if a logged in user is a kingdom officer or admin to determine if the fields should be shown.

I'll reach out to my KD rep to hit the COM up with the question of allowing persons from another org(kingdom) see the mundane names of persons not in their org (kingdom).

if (strlen($request['Token']) > 0 && ($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0 && Ork3::$Lib->authorization->HasAuthority($mundane_id, $request['Type'], $request['Id'], AUTH_EDIT)) { $restricted_access = true; } else { $restricted_access = false; }

	`								'GivenName' => $restricted_access&&$r->restricted==0?$r->given_name:"",
							'Surname' => $restricted_access&&$r->restricted==0?$r->surname:"",
							'OtherName' => $restricted_access&&$r->restricted==0?$r->other_name:"",`

jrtaylor-com avatar Apr 21 '21 13:04 jrtaylor-com

AIBOD will be discussing this in their upcoming meeting. I will post feedback once I receive their direction.

jrtaylor-com avatar Apr 22 '21 19:04 jrtaylor-com

Agenda item was pushed to this Friday (tomorrow). Still waiting for AIBOD response to move forward.

jrtaylor-com avatar May 06 '21 16:05 jrtaylor-com

Sent a followup email to AIBOD.

jrtaylor-com avatar Jun 06 '22 15:06 jrtaylor-com