pickadate.js icon indicating copy to clipboard operation
pickadate.js copied to clipboard

Picker css class conflicts with Google Drive Picker

Open poscar opened this issue 10 years ago • 10 comments

The css class 'picker' used by pickadate.js conflicts with the picker class used by the Google Drive Picker (https://developers.google.com/picker).

This class should be customizable when configuring the plugin, randomly generated, or more unique (e.g. a prefix) so that it doesn't conflict with other plugins.

poscar avatar Jan 15 '15 04:01 poscar

+1 maybe we change .picker to be .pad-picker or .pickadatepicker?

marcucio avatar Jan 15 '15 15:01 marcucio

+1

JeanCarriere avatar Oct 23 '15 13:10 JeanCarriere

+2

youssmak avatar Oct 23 '15 13:10 youssmak

Do you think we could get an update on this ?

JeanCarriere avatar Oct 27 '15 17:10 JeanCarriere

this worked for me

.picker-dialog-content { position: relative; }

felipemarin avatar Dec 07 '15 01:12 felipemarin

@felipemarin thanks. it worked me too.

erata avatar Oct 28 '17 12:10 erata

That works but I think it should be fixed in the next release perhaps? @amsul, would you like me to prepare a PR? I guess it's quite a major change, so perhaps we need to release a new major release?

brendon avatar Dec 02 '18 23:12 brendon

In most cases people can adjust the styles and use scoped styles.

Not sure if we should change this as I did not see more issues and comments related to this.

DanielRuf avatar Dec 04 '18 20:12 DanielRuf

I would agree with @DanielRuf. This can easily be solved with scoped styles - plus it'd be a major breaking change for anyone using the project with custom styles.

Maybe it would be better to add an option that appends a custom prefix to the class names (although the CSS names would somehow need to get prefixed accordingly as well)

amsul avatar Dec 04 '18 21:12 amsul

@DanielRuf, are you referring to adjusting Pickadate's styles? Could you elaborate on this a bit?

The issue did cause me a fair bit of confusion with regards to the google file picker as suddenly it just showed up as a little dot on the screen and it wasn't obvious that Pickadate's style overlap was the cause. Only a random (lucky) google search came up with someone that had a similar problem and had asked about an unrelated error message emitted by google picker.

brendon avatar Dec 04 '18 21:12 brendon