pickadate.js icon indicating copy to clipboard operation
pickadate.js copied to clipboard

Update picker.date.js

Open Shimul22 opened this issue 6 years ago • 5 comments

Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not

Shimul22 avatar Apr 29 '19 05:04 Shimul22

If setAsMaxYear: true --> then the current year will be treated as the last year/max year (in the dropdown)

If setAsMaxYear: false (or not included) --> Then numberYears will be added after current year

This will solve #1161

Shimul22 avatar Apr 29 '19 05:04 Shimul22

Hi @Shimul22,

Thanks for the PR.

Please update the title and commit message and provide some tests if possible.

Can you add this for v5? v3 is not actively developed anymore.

DanielRuf avatar Apr 29 '19 05:04 DanielRuf

@DanielRuf

Please update the title

Can you tell me what do mean by the title?

Can you add this for v5? v3 is not actively developed anymore

Version v5 means future origin?

Shimul22 avatar Apr 29 '19 06:04 Shimul22

Update picker.date.js

This title / message is not sufficient. Please change it do describe your changes. See the other PRs.

DanielRuf avatar Apr 29 '19 07:04 DanielRuf

Version v5 means future origin?

Exactly. This is a full rewrite.

DanielRuf avatar Apr 29 '19 07:04 DanielRuf