lapin icon indicating copy to clipboard operation
lapin copied to clipboard

#372 with comments fixed

Open Mathieu-Lala opened this issue 1 year ago • 2 comments

Fixed the comments for the PR #372.

Mathieu-Lala avatar Jul 18 '23 16:07 Mathieu-Lala

This is now ok for me... but I think we need to consider this a breaking change. If people disable default features e.g. to use another TLS implementation, it will break their code on a minor update which is not acceptable.

Let's queue this for 3.0 which will probably happen once nom 8 and async fn in traits are stable

Keruspe avatar Aug 08 '23 15:08 Keruspe

I think this change on a minor release won't bother the user too much, especially if a clear breaking changes section is added to the changelog.

Mathieu-Lala avatar Aug 08 '23 15:08 Mathieu-Lala

Now that we're going to issue a 3.0 alpha, this can definitely go in!

Thinking back about this, I'd rather change the expect to return an error instead.

I'll probably do that some time next week unless you want to give it a shot

Keruspe avatar Jun 23 '24 06:06 Keruspe

Also, could you please rebase to fix merge conflict?

Keruspe avatar Jun 23 '24 06:06 Keruspe