amqplib icon indicating copy to clipboard operation
amqplib copied to clipboard

added support for 'U' and 'u' to codec

Open luukwullink opened this issue 4 years ago • 3 comments

I had trouble decoding a number (unsigned 16 bit integer) created by a python client (https://github.com/pika/pika) and consumed by this client. I found out that there is no implementation for 'u'.

Let me know if i am missing something, i am not so familiar with nodejs and doing pullrequests ;).

luukwullink avatar Apr 23 '21 14:04 luukwullink

Hi ... there are more types besides just the U that are missing ... please review https://github.com/squaremo/amqp.node/pull/646 that add all of the missing types, many thanks for this amazing project Shlomi Gutman Voicenter CTO

voicenter avatar Sep 07 '21 18:09 voicenter

@cressie176 Do you think we should merge this? See https://github.com/amqp-node/amqplib/pull/646 on same topic, except in this case it's clear how unsupported data was created.

kibertoad avatar Jun 25 '23 13:06 kibertoad

@cressie176 Do you think we should merge this? See #646 on same topic, except in this case it's clear how unsupported data was created.

Sorry, didn't properly understand this before. Yes, I think so - if amqplib clients are going to have to consume stuff published by other libraries with different type keys

cressie176 avatar Apr 11 '24 20:04 cressie176