amphtml
amphtml copied to clipboard
✨ New feature - [ Project TribooAnalytics ] Implement the support for the TribooAnalytics into amp-analytics
We have released a new Analytics system and would like to enable native support for AMP pages. The system detects user interactions on pages and obtains navigation information The GitHub reference is https://github.com/TribooAnalytics/amphtml
@TribooAnalytics looks good, could y'all get the tests green.
@powerivq they wouldn't need to update validator for this change right?
@TribooAnalytics can you also sign CLA?
The required changes have been committed. Some CircleCI "checks" tests are still failing, but they concern other vendors AFAICS. I don't know why CircleCI "end-to-end" test fails.
@TribooAnalytics could you rebase the code. Latest main should have the fix for the deadlinks, ill try and restart the end to end tests to see if its a flake
Hey @alanorozco! These files were changed:
build-system/tasks/storybook/env/amp/package-lock.json
build-system/tasks/storybook/env/amp/package.json
build-system/tasks/storybook/env/preact/package-lock.json
build-system/tasks/storybook/env/preact/package.json
build-system/tasks/storybook/package-lock.json
build-system/tasks/storybook/package.json
Hey @danielrozenberg! These files were changed:
build-system/tasks/visual-diff/package-lock.json
build-system/tasks/visual-diff/package.json
Hey @jpettitt! These files were changed:
extensions/amp-subscriptions-google/0.1/test-e2e/test-amp-subscriptions-google.js
Hey @ampproject/wg-caching! These files were changed:
validator/js/nodejs/index.js
Hi @erwinmombay we did the rebase
Thanks everyone for the support
On Fri, Apr 5, 2024 at 4:20 AM Shihua Zheng @.***> wrote:
Merged #39907 https://github.com/ampproject/amphtml/pull/39907 into main.
— Reply to this email directly, view it on GitHub https://github.com/ampproject/amphtml/pull/39907#event-12366740331, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHCK5DOV3LG6EYYSXFATCJTY3YC7XAVCNFSM6AAAAABE5C6VK2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM3DMNZUGAZTGMI . You are receiving this because you were mentioned.Message ID: @.***>