amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

✨ New feature - [ Project TribooAnalytics ] Implement the support for the TribooAnalytics into amp-analytics

Open TribooAnalytics opened this issue 11 months ago • 4 comments

We have released a new Analytics system and would like to enable native support for AMP pages. The system detects user interactions on pages and obtains navigation information The GitHub reference is https://github.com/TribooAnalytics/amphtml

TribooAnalytics avatar Mar 19 '24 08:03 TribooAnalytics

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 19 '24 08:03 CLAassistant

@TribooAnalytics looks good, could y'all get the tests green.

@powerivq they wouldn't need to update validator for this change right?

erwinmombay avatar Mar 19 '24 19:03 erwinmombay

@TribooAnalytics can you also sign CLA?

powerivq avatar Mar 20 '24 05:03 powerivq

The required changes have been committed. Some CircleCI "checks" tests are still failing, but they concern other vendors AFAICS. I don't know why CircleCI "end-to-end" test fails.

TribooAnalytics avatar Mar 20 '24 17:03 TribooAnalytics

@TribooAnalytics could you rebase the code. Latest main should have the fix for the deadlinks, ill try and restart the end to end tests to see if its a flake

erwinmombay avatar Apr 01 '24 22:04 erwinmombay

Hey @alanorozco! These files were changed:

build-system/tasks/storybook/env/amp/package-lock.json
build-system/tasks/storybook/env/amp/package.json
build-system/tasks/storybook/env/preact/package-lock.json
build-system/tasks/storybook/env/preact/package.json
build-system/tasks/storybook/package-lock.json
build-system/tasks/storybook/package.json

Hey @danielrozenberg! These files were changed:

build-system/tasks/visual-diff/package-lock.json
build-system/tasks/visual-diff/package.json

Hey @jpettitt! These files were changed:

extensions/amp-subscriptions-google/0.1/test-e2e/test-amp-subscriptions-google.js

Hey @ampproject/wg-caching! These files were changed:

validator/js/nodejs/index.js

amp-owners-bot[bot] avatar Apr 03 '24 15:04 amp-owners-bot[bot]

Hi @erwinmombay we did the rebase

TribooAnalytics avatar Apr 04 '24 12:04 TribooAnalytics

Thanks everyone for the support

On Fri, Apr 5, 2024 at 4:20 AM Shihua Zheng @.***> wrote:

Merged #39907 https://github.com/ampproject/amphtml/pull/39907 into main.

— Reply to this email directly, view it on GitHub https://github.com/ampproject/amphtml/pull/39907#event-12366740331, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHCK5DOV3LG6EYYSXFATCJTY3YC7XAVCNFSM6AAAAABE5C6VK2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM3DMNZUGAZTGMI . You are receiving this because you were mentioned.Message ID: @.***>

TribooAnalytics avatar Apr 05 '24 13:04 TribooAnalytics