amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Add improvedigital to RTC callout vendors

Open mnishihan opened this issue 1 year ago • 1 comments

mnishihan avatar Oct 11 '22 14:10 mnishihan

I strongly believe - the CircleCI tests, that are failing, are intermittent, caused by networking issues in CircleCI environment & unrelated with the changes in my PR.

For example, this & this failures are related to PGP key fetching from keybase.io and the other one also related to some XHR failing.

Also note that, yesterday I opened another PR with almost identical changes and all checks were passed.

Is there any way, I can rerun the failed tests, or anyone can do so?? Or should I close this PR and open another to trigger new checks?

TIA

mnishihan avatar Oct 11 '22 15:10 mnishihan

As to the failing builds, you might want to try rebasing the latest main if that happens.

powerivq avatar Nov 01 '22 22:11 powerivq

As to the failing builds, you might want to try rebasing the latest main if that happens.

@powerivq Done.

mnishihan avatar Nov 05 '22 18:11 mnishihan

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

ampprojectbot avatar Nov 06 '22 00:11 ampprojectbot