amphtml
amphtml copied to clipboard
ampproject
✨ [amp-google-read-aloud-player] Adds support for the Read Aloud player Google Analytics 4.
Modifies the validator of amp-google-read-aloud-player extension to also support Google Analytics 4 tracking IDs.
Hey @ampproject/wg-caching! These files were changed:
extensions/amp-google-read-aloud-player/0.1/test/validator-amp-google-read-aloud-player.html
extensions/amp-google-read-aloud-player/0.1/test/validator-amp-google-read-aloud-player.out
extensions/amp-google-read-aloud-player/validator-amp-google-read-aloud-player.protoascii
Hey @alanorozco! These files were changed:
extensions/amp-google-read-aloud-player/amp-google-read-aloud-player.md
![amp-owners-bot[bot] avatar](https://avatars.githubusercontent.com/in/22611?v=4 "Published by a pub.dev verified publisher"){kind=small}
@alanorozco The validator error seems redundant ("ValidatorRulesMakeSense : value_regex_casei must have unicode named groups"). The expression (tracking ID) should only support English letters.
What do you suggest to fix this?
@mhalabi-google I'd suggest using [A-Z0-9] instead of \w.
The test ensures that every \w is followed by \p{L}\p{N}. Although excessive, it prevents developer from forgetting to support Unicode when adding a validator rule. For details see CL/166781166.
@mhalabi-google I'd suggest using [A-Z0-9] instead of \w.
The test ensures that every \w is followed by \p{L}\p{N}. Although excessive, it prevents developer from forgetting to support Unicode when adding a validator rule. For details see CL/166781166.
Done.