amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Fix flaky `amp-list` tests

Open danielrozenberg opened this issue 4 years ago • 5 comments

Disabled in #35360 and #35379

danielrozenberg avatar Jul 22 '21 18:07 danielrozenberg

Are we sure these are actually flaky and not indicating an actual breakage? http://amp-test-cases.appspot.com/test-cases/stats/fail suggests that they are failing in 100% of the last 10 runs.

caroqliu avatar Jul 23 '21 19:07 caroqliu

Are we sure these are actually flaky and not indicating an actual breakage? http://amp-test-cases.appspot.com/test-cases/stats/fail suggests that they are failing in 100% of the last 10 runs.

Good question. Either way, the correct thing to do is to start skipping while we investigate.

samouri avatar Jul 23 '21 19:07 samouri

Are we sure these are actually flaky and not indicating an actual breakage? http://amp-test-cases.appspot.com/test-cases/stats/fail suggests that they are failing in 100% of the last 10 runs.

Good question. Either way, the correct thing to do is to start skipping while we investigate.

Ok, just wanted to clarify. Sometimes skipped tests get forgotten is all. 😅

caroqliu avatar Jul 23 '21 19:07 caroqliu

That's why I always assign the a bug to fix them along with the PR that disables... :)

danielrozenberg avatar Jul 23 '21 19:07 danielrozenberg

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 16 '22 07:10 stale[bot]