amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

AMP-Video-ima add support for AdsRenderingSettings

Open spormeon opened this issue 4 years ago • 7 comments
trafficstars

Description

can AMP-Video-ima add support for AdsRenderingSettings , so as we can limit bitrate to e.g 1000, this is so that we try to limit "heavy ad intervention' taking place, as the SDK can choose ones over this rate with the default -1 (i think) setting.

Could help alot of people who basically have no clue how many ads are being blocked by HAI due to -1 setting choosing higher bitrates etc

Alternatives Considered

can't, can't access this setting currently

Additional Context

No response

spormeon avatar Jun 09 '21 15:06 spormeon

A few thoughts from looking at AdsRenderingSettings.

  1. We'd likely want to exclude certain properties from being configurable. uiElements in particular should be kept as-is for consistency between ad controls and content controls.

  2. I'm not sure what the best markup interface would be. We allow a single <script> tag with JSON inside, but that corresponds to ImaSdkSettings.

Mainly considering adding a data-settings attribute to the script tag, ima/ima-settings/ImaSettings by default to support the previous syntax. ads-rendering/ads-rendering-settings/AdsRenderingSettings otherwise. We likely need to parse and clear props from the latter.

<amp-ima-video>
  <script type="application/json">
    <!-- ImaSettings -->
  </script>
  <script type="application/json" data-settings="ad-rendering">
    <!-- AdsRenderingSettings -->
  </script>
</amp-ima-video>

alanorozco avatar Jun 09 '21 15:06 alanorozco

whichever way works would be my vote

spormeon avatar Jun 09 '21 18:06 spormeon

any more thoughts on implementing this?

spormeon avatar Jul 07 '21 18:07 spormeon

Hi, Any intention to do this?

spormeon avatar Sep 03 '21 16:09 spormeon

@alanorozco is there any chance of getting this implemented, the HAI ads are getting more and more frequent, so this will help people alleviate it

spormeon avatar Oct 29 '21 18:10 spormeon

@alanorozco Any word of this, not having the ability to set tjis is still having effect on HAI being triggered, by what are Google ads in effect

spormeon avatar Feb 26 '22 13:02 spormeon

any info on this, noone has said anything on implementation

spormeon avatar Aug 11 '22 20:08 spormeon