amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard
verified publisher icon ampproject

Change window.context API to avoid problematic terms

Open calebcordry opened this issue 5 years ago • 17 comments

We will still need to maintain backwards compatibility, so will likely alias to the new name.

to/ @ampproject/wg-monetization

calebcordry avatar Oct 21 '20 16:10 calebcordry

I'd suggest adding window.coordinator as an alias for window.master

jeffkaufman avatar Oct 21 '20 18:10 jeffkaufman

and computeInCoordinatingFrame for computeInMasterFrame

jeffkaufman avatar Oct 21 '20 18:10 jeffkaufman

Hello, I took up to change computeInCoordinatingFrame to computeInMasterFrame. Didn't find any instances of window.master though. Could you please check my PR? https://github.com/ampproject/amphtml/pull/38107

Jns234 avatar Apr 18 '22 06:04 Jns234

Please ignore what I did, instead of creating an alias I just renamed it.

Jns234 avatar Apr 25 '22 14:04 Jns234

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 06:06 stale[bot]

is this issue fixed

Blast-git avatar Feb 04 '25 01:02 Blast-git

Oke

MuhammadSyauqiMurtadlo avatar Feb 20 '25 22:02 MuhammadSyauqiMurtadlo

how can i work on this issue as I am new

ghost avatar Apr 18 '25 11:04 ghost

hey how can I work upon this issue. Can you brief me about it?

Nkpro29 avatar Apr 22 '25 07:04 Nkpro29

refactor: add window.coordinator as alias to window.context for inclusive naming

Added window.coordinator as an alias to window.context to support more inclusive terminology, while maintaining backward compatibility.

Refs: #30789

Swapnil252383 avatar Jul 18 '25 08:07 Swapnil252383

Thanks for raising this, @calebcordry . I understand that we need to replace the ambiguous or we can say problematic window.context naming with a more inclusive term (e.g. aliasing it to window.coordinator) while preserving backwards compatibility. I’d be happy to implement this assign this issue to me and I’ll get started on a PR.

mayanksingh-27 avatar Aug 01 '25 07:08 mayanksingh-27

Can I solve this?

ZunedKhan07 avatar Aug 12 '25 07:08 ZunedKhan07

I think you can solve this

ravin00 avatar Aug 20 '25 21:08 ravin00

Hello, I’m new to contributing to this project and would love to take this issue as my first PR. Could I be assigned to it if this still open?

cmdsreedev avatar Sep 14 '25 04:09 cmdsreedev

Hello, Is the issue resolved , I want to fix this issue.

om-halder avatar Sep 29 '25 20:09 om-halder

Could I be assigned to it if this still open?

ayushphiyak avatar Oct 01 '25 13:10 ayushphiyak

Replacing window.master with window.coordinator

Replacing computeInMasterFrame with computeInCoordinatingFrame

Maintaining backward compatibility by aliasing old names to new ones

Lintshiwe avatar Oct 28 '25 17:10 Lintshiwe