amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Intent to implement: Create AMP myvideo player Component

Open Emiliano-Bucci opened this issue 5 years ago • 9 comments

Summary

Create an AMP component that embeds the MyVideo Video Player: <amp-myvideo-player>. This component will be used by publishers using TheOutPlay platform.

The player will be embedded inside an iframe. All data-attributes are obtained during the creation of the Player Configuration in the TheOutPlay platform.

Usage example

<amp-myvideo-player
  data-widget="intext"
  data-publisher="123"
  data-selection="234"
  data-configuration="342"
  data-hash="xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
  layout="responsive"
  width="480"
  height="270">
</amp-myvideo-player />

Detailed info about the component can be found here -> https://github.com/Myntelligence/amphtml/tree/amp-myvideo-player/extensions/amp-myvideo-player

/cc @cramforce

Thanks, Emiliano.

Emiliano-Bucci avatar May 12 '20 09:05 Emiliano-Bucci

@Emiliano-Bucci some update? /cc @cramforce

dev-myvideo avatar May 26 '20 10:05 dev-myvideo

Looks like your original notification didn't go through.

@alanorozco Are you handling video players these days?

This LGTM from my end.

cramforce avatar May 26 '20 13:05 cramforce

@cramforce Thanks for the answer! I'll wait then for the approval of @alanorozco and then, in case, i'll create the pr.

Emiliano-Bucci avatar May 26 '20 14:05 Emiliano-Bucci

@alanorozco Is there any update on this? :)

Emiliano-Bucci avatar Jun 10 '20 08:06 Emiliano-Bucci

@Emiliano-Bucci Apologies for the delay.

The API seems reasonable to me.

Is myvideo the product name? I worry it might be confusing because we'd have:

  • amp-video
  • amp-video-iframe
  • amp-myvideo-player

And just by name the last one seems like a nonsequitur :)

alanorozco avatar Jun 16 '20 17:06 alanorozco

@alanorozco Hi, thanks for the answer! Yes, myVideo is the product name so for us is vital to keep it :)

Emiliano-Bucci avatar Jun 22 '20 07:06 Emiliano-Bucci

Hello @alanorozco and @cramforce this project is really important for our business and we are blocked at this point. Could someone give us feedback?

dev-myvideo avatar Oct 30 '20 16:10 dev-myvideo

Hello @alanorozco and @cramforce we are really blocked. Could you please give us feedback on how to proceed?

dev-myvideo avatar Feb 19 '21 11:02 dev-myvideo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 08:07 stale[bot]