amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Add integration test for shadow dom

Open jpettitt opened this issue 6 years ago • 8 comments

We've had multiple issues with DOM inconsistencies when AMP code is imported through a shadow dom based mechanism (in Polymer ), see list below. We need some shadow dom integration tests.

Here some of the issues: #19434 amp-experiment #19694 amp-subscriptions-google #12912 amp-ads #12388 amp-img #12151 amp-list #10799 amp-access

jpettitt avatar Dec 21 '18 16:12 jpettitt

Here is another one: https://github.com/ampproject/amphtml/issues/20008

justforfun avatar Jan 15 '19 09:01 justforfun

We a brand new issue of the same kind: https://github.com/ampproject/amphtml/issues/20400

justforfun avatar Jan 17 '19 12:01 justforfun

Is this on the roadmap?

cc @rudygalfi

jpettitt avatar Jan 18 '19 21:01 jpettitt

@rsimha let us know your thoughts here.

rudygalfi avatar Jan 18 '19 21:01 rudygalfi

I think this can be covered by E2E tests now. @prateekbh Can you comment?

rsimha avatar Jul 16 '19 20:07 rsimha

Yes, I had a conversation around the same and definitely looks like this can be done via e2e tests

prateekbh avatar Jul 16 '19 20:07 prateekbh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 27 '21 16:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 18:07 stale[bot]