amp.dev icon indicating copy to clipboard operation
amp.dev copied to clipboard

Animated snackbar example broken for inline demo

Open jaygray0919 opened this issue 5 years ago • 3 comments

for https://amp.dev/documentation/examples/visual-effects/animated_snackbar/?format=websites#asd

/s/dissappear/disappear

also, the inline example (for the target page) does not work as advertised in the sample code (it does not disappear according to the terms in the code). in contrast, playground works as advertised

jaygray0919 avatar Dec 18 '20 20:12 jaygray0919

fixed typo in d17751b

snackbar does work, but you need to scroll way down and way back up - might be some kind of optimization that is only triggering the animation if something is in the viewport?

patrickkettner avatar Dec 21 '20 16:12 patrickkettner

agree - it does not work as advertised in the sample code; it has different behavior.

jaygray0919 avatar Dec 22 '20 16:12 jaygray0919

absolutely! your report was correct, just wanted to add some context for anyone looking at a fix

patrickkettner avatar Dec 22 '20 16:12 patrickkettner