amp-wp icon indicating copy to clipboard operation
amp-wp copied to clipboard

Add a fallback Settings.

Open milindmore22 opened this issue 2 years ago • 4 comments

Feature Description

We are getting a lot of support topics where they can't access settings this might be due to third-party plugins or themes conflicting sometimes wrong configuration etc. we can't pinpoint a single issue. example topics: topic1 topic2, topic3

My idea is to add fallback settings with something simple like Settings API or something custom but simple and doesn't use scripts, where users can at least access basic settings like template mode, Reader Theme selection, Supported template, Mobile redirection, Plugin suppression, etc.

The Fallback Setting will come into action (we will show a link or button for fallback settings) on LoadingError

This will enable users to access settings with their conflicting plugin or theme.

Adding it to the loading error will indicate that there are more features like site scan and wizard that are not working for them because of the conflicting plugins and they are using fallback settings.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

milindmore22 avatar Jun 15 '22 13:06 milindmore22

another support topic

milindmore22 avatar Jun 20 '22 10:06 milindmore22

Adding fallback settings would essentially be bringing back the old settings screen which relied on the Settings API, with full page reloads and no JS being required. However, I'd want to avoid adding a parallel UI for managing settings. Maybe we can be more aggressive about ensuring our polyfilled scripts are loaded? What if the loading error message had a link which had a query parameter that caused the page to load with our script polyfills forced? Currently polyfills are only loaded on older versions of WordPress (<5.6). If we force our polyfilled scripts in ≥5.6 if requested, would this allow the pages to load successfully?

westonruter avatar Jul 26 '22 21:07 westonruter

@milindmore22 Do you think that a WP-CLI interface for the settings (https://github.com/ampproject/amp-wp/issues/5783) would satisfy this well enough?

westonruter avatar Nov 30 '22 00:11 westonruter

@westonruter yes, that will also work! cc : @thelovekesh

milindmore22 avatar Nov 30 '22 09:11 milindmore22