amp-wp icon indicating copy to clipboard operation
amp-wp copied to clipboard

Add ability to override whether mobile switcher link is displayed

Open westonruter opened this issue 4 years ago • 3 comments

Feature description

There have been a few requests regarding the mobile switcher link in the footer. Some users in Transitional mode have an AMP version that is complete parity with non-AMP version. See support topic. For them, they may want to still have mobile redirection enabled, but skip showing the link.

What remains to be determined is whether there should be UI for this. If so, then the Mobile Redirection section on the settings screen should perhaps be turned into a drawer. The redirection toggle can then go into this drawer, along with a toggle for whether to show the mobile switcher link on AMP pages, and conversely whether to show the corresponding same link on non-AMP pages. Otherwise, we may opt to control this all programmatically via a filter like amp_mobile_version_switcher_link_displayed (and as mentioned in #5378, if such a filter has been added then any corresponding UI would need to be disabled since it would be potentially overridden).

This is closely related to #5293 (and perhaps an expansion thereof) where some users in Reader mode do not want to have mobile redirection enabled, and yet they really miss the "Exit reader mode" link in the header. For such users, they should be able to force the mobile switcher link to be displayed even though mobile redirection is disabled.

For whether we add a UI, we need to gather more data to learn whether it is a common enough request to add UI complexity. However, if this is collapsed in a Mobile Redirection drawer, then this would be mitigated.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Users with mobile direction enabled can opt to hide the mobile version switcher link on AMP pages.

Implementation brief

QA testing instructions

Demo

Changelog entry

westonruter avatar Sep 15 '20 20:09 westonruter

Hello! Any news about this feature?

jcvignoli avatar May 23 '22 05:05 jcvignoli

@jcvignoli Hi. No news, but as indicated in the support topic you can hide it with this CSS (e.g. in the Customizer's Additional CSS section):

#amp-mobile-version-switcher {
	display: none;
}

westonruter avatar May 23 '22 19:05 westonruter

Thanks, but was looking for a more sustainable way, like a function...

jcvignoli avatar May 23 '22 19:05 jcvignoli