amp-toolbox

amp-toolbox copied to clipboard

The linter issues a warning if some schema.org types can't be found. It should "allow" more types:  (See https://developers.google.com/search/docs/guides/about-amp.) See also #397.

ithinkihaveacat

Report line/column numbers in the output

1

Report line/column numbers associated with error/warnings where appropriate. (This SO question and answer might be useful to get started: https://stackoverflow.com/questions/49018783/element-startindex-is-undefined-when-using-withstartindices-option-in-cheerio.)

ithinkihaveacat

Currently, the same warning message is repeated for each error: ``` [I] ~/P/a/p/linter (master↑1|✚11) $ amp lint https://amp.dev PASS 1x1 images are specified by WARN All have reasonable width and...

sebastianbenz

Add `origins` cli subcommand

2

For our cors implementation, I'd like to automatically generate the list of allowed origins at build-time (we have staging/production environments, so we can't just hard-code, and would like for them...

defjosiah

Linter: don't show rules in the report that don't apply to the actual format

1

For example, linting amp.dev will print: ``` Story is self-canonical? (PASS) ``` even though it's not an AMP story.

sebastianbenz

this page https://github.com/ampproject/amp-toolbox/tree/master/packages/optimizer-express references this link: https://badge.fury.io/js/@ampproject/toolbox-optimizer-express but it doesn't work

BorntraegerMarc

Optimize other supported font providers

2

See what we can do to optimise font loading from the other supported font services: Typography.com: https://cloud.typography.com Fonts.com: https://fast.fonts.net Typekit: https://use.typekit.net Font Awesome: https://maxcdn.bootstrapcdn.com, https://use.fontawesome.com //cc @westonruter @dakkad

sebastianbenz

cache-url: Remove TextEncoder

1

see #132 TextEncoder is not supported on some browsers, thus it would be good to remove this and use something else. cc @sebastianbenz @kristoferbaxter

torch2424

[optimizer] Enable adding custom transformation to the config

3

The default config for the optimizer is not exposed. When a developer needs to add a custom config it is necessary to re-add the whole configuration, like in the example...

andreban

Currently, if the input page already preloads v0.js, a second rtv preload will be added: ``` ``` //@dakkad

sebastianbenz