amp-toolbox icon indicating copy to clipboard operation
amp-toolbox copied to clipboard

IsValid rule not being used inside linter?

Open jwmann opened this issue 4 years ago • 2 comments

Is there a particular reason why this rule isn't being run in the linter? I feel like this is the most important rule to be run.

I also don't see an option that I can pass to add it to the list of rules to check against.

jwmann avatar Apr 07 '20 20:04 jwmann

@ithinkihaveacat FYI

sebastianbenz avatar Apr 14 '20 17:04 sebastianbenz

I the validator should run. I don't remember exactly why it doesn't, but I think it might have been because there wasn't a good way to cache the validator. Created #712 for this, and have started work on it. (Didn't quite finish in my time-boxed 1hr…)

ithinkihaveacat avatar Apr 15 '20 07:04 ithinkihaveacat