amp-toolbox icon indicating copy to clipboard operation
amp-toolbox copied to clipboard

Should relative hosts support be removed from optimizer?

Open mdmower opened this issue 5 years ago • 2 comments

Based on https://github.com/ampproject/amphtml/issues/27546 , it sounds like absolute, HTTPS URLs should be required for parameter ampUrlPrefix used in DomTransformer.transformHtml().

In optimizer,

  • should we remove support for relative hosts?
  • should we require HTTPS URLs?

We should keep in mind that some users may want to test optimized AMP pages in local dev environments (e.g. localhost or HTTP), so it may be best to make no changes.

mdmower avatar Apr 05 '20 21:04 mdmower

My recommendation after looking at optimizer for a bit: require absolute URLs. This is mostly so that AmpBoilerplateTransformer can inline the correct v0.css. I can go either way on allowing or forbidding HTTP URLs.

Work in progress: https://github.com/mdmower/amp-toolbox/commits/pr-absolutehost

mdmower avatar Apr 07 '20 04:04 mdmower

+1 to requiring absolute hosts

sebastianbenz avatar Apr 14 '20 17:04 sebastianbenz