amp-toolbox-php icon indicating copy to clipboard operation
amp-toolbox-php copied to clipboard

Published 20 hours ago • verified publisher icon ampproject

Pipes in href attributes are encoded by DOMDocument

Open schlessera opened this issue 4 years ago • 2 comments

When pipes are being used in href attributes, like it is the case for Google Fonts links, then the DOMDocument seems to encode these pipes, making them ugly to read.

_ 2021-02-19 at 9 26 46 AM p-toolbox-php

schlessera avatar Feb 19 '21 09:02 schlessera

Just a cosmetic issue though, right? Functionally equivalent.

westonruter avatar Feb 19 '21 16:02 westonruter

Yes, purely cosmetic. Again something that makes testing more difficult across platforms, though. The above is the output from a PHPUnit test failing against the NodeJS spec test suite.

schlessera avatar Feb 19 '21 16:02 schlessera