amp-toolbox-php
amp-toolbox-php copied to clipboard
Raise PHPStan level for the `amp/common` package to 5
Feature description
The Common package (ampproject/common
) is currently sitting at and enforcing level 4 of PHPStan static analysis.
There are 2 errors that need to be fixed so that we can raise the level to 5 and enforce this new quality level in Travis CI.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- PHPStan does not show any detected errors when run on level 5.
Implementation brief
- Change the level to
5
in the filephpstan.neon.dist
. - Run
composer analyze
. - Fix detected errors until no more are found.