amp-toolbox-php
amp-toolbox-php copied to clipboard
ampproject
Creation of a Symfony bundle
Hi all.
My colleagues and I are very interested in dedicate time to create a Symfony bundle for the easy integration and configuration of this library. I'd like to know if someone is already on this or if there is someone interested. @dritter I've seen you were using something already. Is it correct?
Marco
@marco-msg-ferrari I discussed internally how we want to handle third-party integrations like this.
While we absolutely support and assist work on such integrations, we won't host them within this organization (the ampproject GitHub organization) for now. But I'd like to add a section to the README.md file with links to integrations, so please let me know once you've decided on where to host the code.
Also, while this library is certainly usable as-is already (and I'll be publishing it to Packagist soon as well), keep in mind that there's a few transformers still missing that need to be moved from the ampproject/amp-wp plugin (where some of these are currently hard-coded) into separate transformers within this library. So there's a bit of work still before we reach a 1.0 release.
Another note: Licensing information is currently contradicting and still in flux. I'll probably update that with final information very soon.
Thank a lot @schlessera . We'll probably use our organization for now ( https://github.com/holadev ). We'll discuss it internally and let you know the final url. I'm aware that there is works to be done until you can call it 1.0 but I prefer to get the ball rolling and be prepared and tested in the mean time. Mon the 2nd is a bank holiday in Madrid (where our HQ is located) so expect word about this issue on Tue the 3rd. Thanks a lot for the work you're doing.
Hi @marco-msg-ferrari ,
yes, we are already using the EventSubscriber I posted in https://github.com/ampproject/amp-wp/issues/5538#issuecomment-716665606 . Feel free to use it :) We are interested in using a complete bundle for sure. So I'll keep an eye on your org. :eyes:
This is only at the very beginning but there you can find the repo: https://github.com/holadev/amp-toolbox-bundle In the next days we will create all integrations (packagist, travis etc) and some code.
Hello everybody we think we have a stable release: https://github.com/holadev/amp-toolbox-bundle/releases/tag/v0.1.1 https://packagist.org/packages/holadev/amp-toolbox-bundle