amp-sw icon indicating copy to clipboard operation
amp-sw copied to clipboard

AmpDocumentNetworkFirst.makeRequest return is not nullable but method body implies that it might be nullable

Open erwinmombay opened this issue 5 years ago • 0 comments

inside the body of makeRequest in the AmpDocumentNetworkFirst class there is a check for request where it could be nullable but we return request anyways as the base case and don't state it in the method signature return type.

question really is, does calling makeRequest return something that is nullable from the NetworkFirst implementation in workbox?

erwinmombay avatar Aug 05 '19 21:08 erwinmombay