Amplitude-iOS icon indicating copy to clipboard operation
Amplitude-iOS copied to clipboard

Published 20 hours ago • verified publisher icon amplitude

refactor: Added name for background task started on enterBackground

Open antohisorin opened this issue 1 year ago • 1 comments

Summary

Added name for background task started on enterBackground to improve debugging.

Checklist

  • [X] Does your PR title have the correct title format?
  • [X] Does your PR have a breaking change?: NO

antohisorin avatar Jan 22 '24 19:01 antohisorin

@Mercy811 @qingzhuozhen @justin-fiedler is there a way we can land this MR? We need to track background tasks and what happens to them in our app. We don't want to fork the amplitude SDK only for this small change.

antohisorin avatar Mar 07 '24 06:03 antohisorin

@Mercy811 @qingzhuozhen @justin-fiedler is there a way we can land this MR? We need to track background tasks and what happens to them in our app. We don't want to fork the amplitude SDK only for this small change.

Sure @antohisorin. I can help get this merged and release a new version. Dropped a comment

izaaz avatar Mar 11 '24 18:03 izaaz

@Mercy811 @qingzhuozhen @justin-fiedler is there a way we can land this MR? We need to track background tasks and what happens to them in our app. We don't want to fork the amplitude SDK only for this small change.

Sure @antohisorin. I can help get this merged and release a new version. Dropped a comment

Updated. Sorry I don't know why I had duplicate values there.

antohisorin avatar Mar 11 '24 18:03 antohisorin

Thanks @antohisorin . I'll get this merged and deployed once the tests pass.

izaaz avatar Mar 11 '24 19:03 izaaz

:tada: This PR is included in version 8.18.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 12 '24 20:03 github-actions[bot]