Amplitude-TypeScript icon indicating copy to clipboard operation
Amplitude-TypeScript copied to clipboard

feat(analytics-browser): set default for fetchRemoteConfig option to true

Open Dogfalo opened this issue 9 months ago • 2 comments

Summary

This PR sets the default for the fetchRemoteConfig option to be true. The goal of this is to allow more users, excluding those who have set it to false explicitly, to be able to control their SDK configuration through the Amplitude platform.

Checklist

  • [ ] Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

Dogfalo avatar Mar 26 '25 19:03 Dogfalo

Can we also update the default value and add a url link (for example, https://app.amplitude.com/data/amplitude/{your org name}/settings/autocapture) to the app or a doc to where customers can edit remote config?

https://github.com/amplitude/Amplitude-TypeScript/blob/823b695c3a67b4c44f4a2ba5a1f7f766845e9e55/packages/analytics-core/src/types/browser-config.ts#L79-L82

@Mercy811 Updated the value in the comment and added an example link. Should this also be updated? packages/analytics-types/src/config/browser.ts

Dogfalo avatar Mar 27 '25 17:03 Dogfalo

Can we also update the default value and add a url link (for example, https://app.amplitude.com/data/amplitude/{your org name}/settings/autocapture) to the app or a doc to where customers can edit remote config? https://github.com/amplitude/Amplitude-TypeScript/blob/823b695c3a67b4c44f4a2ba5a1f7f766845e9e55/packages/analytics-core/src/types/browser-config.ts#L79-L82

@Mercy811 Updated the value in the comment and added an example link. Should this also be updated? packages/analytics-types/src/config/browser.ts

The latest version with turn remote config on by default only depends on the core package. So I don't think we need to update types package.

Mercy811 avatar Mar 28 '25 17:03 Mercy811