serverless-domain-manager Updating ACM certificate ARN doesn't make any changes

Updating ACM certificate ARN doesn't make any changes

Open abbathaw opened this issue 3 years ago • 5 comments

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Support Question

Question I have a new ACM certificate (aws-managed) and I want to update the app's API gateway custom domain endpoint configuration. After updating the serverless configuration with the new certificate ARN, and deploying, there were no changes being reflected on the endpoint configuration in the API Gateway (Custom Domain names) UI. The config on the UI still showed that the old certificate was being used.

I eventually manually updated the configuration to the new certificate from the console UI. I redeployed again, no changes happening from the plugin.

Command Run sls deploy

Console Output (anonymized)

Serverless Domain Manager: Info: Found apiId: xxxxxxxx for xxxxx.myapp.io
Serverless Domain Manager: Info: Updated API mapping from 'api'
                     to 'api' for xxxxx.myapp.io
Serverless Domain Manager: Info: 
Serverless Domain Manager Summary
Serverless Domain Manager: Info: Distribution Domain Name
Serverless Domain Manager: Info:   Domain Name: xxxxx.myapp.io
Serverless Domain Manager: Info:   Target Domain: d-xxxxxxx.execute-api.us-west-2.amazonaws.com
Serverless Domain Manager: Info:   Hosted Zone Id: xxxxxxx
Done in 19.62s.

Domain Manager Configuration

custom:
  customDomain:
    basePath: api
    stage: ${self:provider.stage}
    endpointType: regional
    domainName: ${self:custom.configurations.${self:provider.stage}.domainName}
    certificateName: '*.myapp.io'
    certificateArn: ${self:custom.configurations.${self:provider.stage}.certificateArn} // this is the value that was updated
    createRoute53Record: false

Versions

Domain Manager version(s): v5.0.0
Node/npm version: Node 12.15.0
Serverless Version: v2.8.0
Lambda Code : javascript

Oct 26 '20 15:10 abbathaw

I ran to this same issue. Changing the ACM certificate ARN in configuration did not update the certificate for the API GW domain automatically. Had to do that manually from AWS console.