amplication icon indicating copy to clipboard operation
amplication copied to clipboard

feat(dsg): upgrade react-admin to v4

Open Meyazhagan opened this issue 1 year ago • 4 comments

Close: #7395

PR Details

PR Checklist

  • [ ] Tests for the changes have been added
  • [ ] npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Meyazhagan avatar Feb 13 '24 15:02 Meyazhagan

Thanks @Meyazhagan! we will review it ASAP.

overbit avatar Feb 14 '24 11:02 overbit

@overbit should we test if all plugins work as expected after this version bump?

Shurtu-gal avatar Feb 14 '24 11:02 Shurtu-gal

@Shurtu-gal yep, that will be necessary. Enterprise users currently have the ability to select the DSG version so they could stay with the current plugin versions but all others will need to have all the latest official plugin versions fully working with react admin 4.

Special attention might be required for the Auth plugins as with the latest react admin, there are changes to the AuthProvider interface and hooks.

@mulygottlieb this needs to be taken into consideration

overbit avatar Feb 14 '24 12:02 overbit

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d2494359b81d77694d8d691c3e1eac7fb97d7d0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Feb 15 '24 02:02 nx-cloud[bot]

@Meyazhagan @Shurtu-gal @overbit I am sorry, but I'm not sure why we are investing time in this. We focus on backend services generation, and the react admin UI is a nice-to-have utility. Spending time on this + adding the potential risk of breaking existing plugins and requiring significant regression testing doesn't make sense to me.

mulygottlieb avatar Feb 26 '24 06:02 mulygottlieb